Add nf-float 0.4.5 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a compatibility issue between MMC and AWS API. The endpoint for AWS region us-east-1 is different with other regions. The algorithm used by MMC to provide the default endpoint does not work. Add support in nf-float plugin to retrieve the endpoint configuration from `aws.client.endpoint` and supply this to MMC if available. Do not change the default `scratch` option if user has local work dir. Changes is available at: MemVerge/nf-float#94 MemVerge/nf-float#95
jealous
force-pushed
the
release/0.4.5
branch
from
7797eb7
to
0305922
Compare
sateeshperi
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a compatibility issue between MMC and AWS API. The endpoint for AWS region us-east-1 is different with other regions. The algorithm used by MMC to provide the default endpoint does not work.
Add support in nf-float plugin to retrieve the endpoint configuration from
aws.client.endpointand supply this to MMC if available.Do not change the default
scratchoption if user has local work dir.Changes are available at:
MemVerge/nf-float#94
MemVerge/nf-float#95