WIP: add config option to omit script from payload #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some script payloads can be large (MBs), especially when templating in thousands of input files.
Many firewalls are averse to large payloads, and in many cases, it just doesn't make sense to sling megabytes across a network.
I propose a config option to omit the whole script from payloads here.
Unfortunately, I hit some snags while testing. I tried in amazoncorretto docker images, 17, 19 and 21. None of them built out of the box using most up-to-date nextflow.
I ran once (per the readme):
And then:
After using java19 and updating
gradle-wrapper.properties
to match nextflow, I got the furthest but failed with:Anyway, if you point me in the right direction to get this built/tested, happy to do so. Im also happy to update the docs.
Thanks!