Skip to content
This repository was archived by the owner on Aug 20, 2024. It is now read-only.

Conversation

@mirpedrol
Copy link
Collaborator

No description provided.

@mirpedrol mirpedrol requested review from ewels and nvnieuwk October 12, 2023 06:55
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Why both camelCase and snake_case?

@mirpedrol
Copy link
Collaborator Author

Why both camelCase and snake_case?

We discussed this in the PR with this feature.
It should be camelCase because it is a nextflow parameter. But we are using snake_case in nf-core also for other functionalities, so we would need to have both monochrome_logs and monochromeLogs in the template. Do you think it's too confusing?

Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirpedrol mirpedrol merged commit 357fc59 into nextflow-io:master Oct 12, 2023
@mirpedrol mirpedrol deleted the expectedparameters branch October 12, 2023 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants