Fix fetching new remote branch in multi-revision mode #6733
+97
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on mode This test demonstrates the bug where trying to fetch a branch that exists on the remote but not in the local bare repository fails. Signed-off-by: Rob Syme <rob.syme@seqera.io> Signed-off-by: Rob Syme <rob.syme@gmail.com>
…on mode The refSpecForName method was only checking local refs in the bare repository. For branches that exist on the remote but haven't been fetched yet, this caused the method to incorrectly treat the branch name as a commit SHA, resulting in a fetch error. Now the method queries remote refs via ls-remote when the revision is not found locally, allowing new remote branches to be fetched correctly. Fixes the error: 'Remote does not have <branch> available for fetch' Signed-off-by: Rob Syme <rob.syme@seqera.io> Signed-off-by: Rob Syme <rob.syme@gmail.com>
Signed-off-by: Rob Syme <rob.syme@seqera.io> Signed-off-by: Rob Syme <rob.syme@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refSpecForName()method now queries remote refs vialsRemote()when a revision is not found locally, before falling back to treating it as a commit SHA@Memoizedhelper methodfetchRemoteRefs()to cache results and avoid redundant network callsFixes #6732
Test plan
should fetch new remote branch not in local bare repothat verifies fetching a branch not present locallyshould create correct RefSpec for branches tags and commitsthat verifies fallback behavior without network accessnextflow pull nf-core/fetchngs -revision preview-26-04now works correctly🤖 Generated with Claude Code