-
Notifications
You must be signed in to change notification settings - Fork 759
Add onWorkflowPublish event to TraceObserverV2 #6701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3a8a2d1 to
b5a155d
Compare
Fire a new event during PublishOp::onNext for each value being published to a workflow output. Unlike onWorkflowOutput which fires after completion, this provides real-time notification with the complete channel value as each emission is published. Signed-off-by: Rob Syme <rob.syme@gmail.com>
b5a155d to
6333b8c
Compare
….groovy Signed-off-by: Rob Syme <rob.syme@gmail.com>
|
I think this is the right idea I'm wondering whether we should only fire this event for queue channels and not value channels. Since a value channel is just a single value, the |
pditommaso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a developer I wonder what's the difference of onWorkflowOutput vs onWorkflowPublish vs onFilePublish.
At least there should be a very detailed docs and javadoc describing what event is meant for and when to use it
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
|
I updated the java docs to be more comprehensive. I will follow up with a guide in the docs for how to use the trace observer |
|
Amazing. Thanks team ❤️ 🙏 |
Summary
Adds a new
onWorkflowPublishevent toTraceObserverV2that fires for each value as it is published to a workflow output.This addresses the request in #6680 for richer context during file publishing. The new event provides:
name- the workflow output name (e.g., "alignedBams")value- the complete channel value being published (which may contain files alongside metadata like sample IDs)Event timeline
Channel value 1 arrives → onWorkflowPublish ← NEW (fires per value)
→ onFilePublish (for each file)
Channel value 2 arrives → onWorkflowPublish ← NEW
→ onFilePublish (for each file)
...
All values complete → onWorkflowOutput (fires once at end)
Unlike
onWorkflowOutputwhich fires after all values have been published,onWorkflowPublishfires in real-time as each value flows through, givingTest plan
OutputDslTesttests updated to verifynotifyWorkflowPublishis called