Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint and format commands #5908

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bentsherman
Copy link
Member

To test:

$ ./launch.sh lint .
$ ./launch.sh format .

TODO:

  • Update docs
  • Prettify console logging

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman requested a review from ewels March 20, 2025 20:22
@bentsherman bentsherman requested a review from a team as a code owner March 20, 2025 20:22
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit aca38da
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67dc7906b33d8c0008a6639f

@bentsherman bentsherman requested a review from tom-seqera March 20, 2025 21:47
@bentsherman
Copy link
Member Author

@tom-seqera adding you as an optional reviewer to help you get familiar with the code

@bentsherman bentsherman added this to the 25.04.0 milestone Mar 20, 2025
@pditommaso
Copy link
Member

Made a quick test

./main.nf at line 20, column 1: Invalid include source: 'file:///Users/pditommaso/Projects/rnaseq-nf/modules/rnaseq.nf'
./main.nf at line 21, column 1: Invalid include source: 'file:///Users/pditommaso/Projects/rnaseq-nf/modules/multiqc/main.nf'
./main.nf at line 37, column 3: `RNASEQ` is not defined
./main.nf at line 38, column 3: `MULTIQC` is not defined
./main.nf at line 38, column 12: `RNASEQ` is not defined

./modules/rnaseq.nf at line 3, column 1: Invalid include source: 'file:///Users/pditommaso/Projects/rnaseq-nf/modules/index/main.nf'
./modules/rnaseq.nf at line 4, column 1: Invalid include source: 'file:///Users/pditommaso/Projects/rnaseq-nf/modules/quant/main.nf'
./modules/rnaseq.nf at line 5, column 1: Invalid include source: 'file:///Users/pditommaso/Projects/rnaseq-nf/modules/fastqc/main.nf'
./modules/rnaseq.nf at line 13, column 5: `INDEX` is not defined
./modules/rnaseq.nf at line 14, column 5: `FASTQC` is not defined
./modules/rnaseq.nf at line 15, column 5: `QUANT` is not defined
./modules/rnaseq.nf at line 15, column 11: `INDEX` is not defined
./modules/rnaseq.nf at line 18, column 6: `QUANT` is not defined
./modules/rnaseq.nf at line 18, column 22: `FASTQC` is not defined

./nextflow.config at line 130, column 24: `AZURE_BATCH_ACCOUNT_NAME` is not defined
./nextflow.config at line 131, column 23: `AZURE_BATCH_ACCOUNT_KEY` is not defined
./nextflow.config at line 137, column 24: `AZURE_STORAGE_ACCOUNT_NAME` is not defined
./nextflow.config at line 138, column 23: `AZURE_STORAGE_ACCOUNT_KEY` is not defined
  • It would be nice to use relative paths e.g. modules/rnaseq.nf instead `file:///Users/pditommaso/Projects/rnaseq-nf/modules/rnaseq.nf
  • alternatively, at least strip the file:// prefix.
  • not sure to understand why line 20 and 21 were reported as invalid includes

Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to add some unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants