Refactor CID store as plugin #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
jorgee
force-pushed
the
cid-store-plugin
branch
from
7484816 to
cb5c047
Compare
pditommaso
commented
Mar 12, 2025
modules/nf-commons/src/main/nextflow/plugin/PluginsFacade.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/file/RealPathAware.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
|
@jorgee let me know if it's ready to go |
|
It is ready |
jorgee
approved these changes
Mar 12, 2025
jorgee
added a commit
that referenced
this pull request
Mar 12, 2025
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: jorgee <jorge.ejarque@seqera.io> Co-authored-by: jorgee <jorge.ejarque@seqera.io>
jorgee
added a commit
that referenced
this pull request
Mar 12, 2025
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: jorgee <jorge.ejarque@seqera.io> Co-authored-by: jorgee <jorge.ejarque@seqera.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the CID store as a plugin dependency. I still have some problem to make loading properly.
The main change is in the
CmdCidthat requires to remain in the main module. Therefore the main logic has been moved into CidOperationImpl class.Still not sure it's the proper way to organise this extension. Maybe it could be better to move as a core module (as nf-commons, nf-httpfs)