Decouple CID FileSystem from Local file system and other fixes #5866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pditommaso
reviewed
Mar 10, 2025
modules/nextflow/src/main/groovy/nextflow/data/cid/CidHistoryFile.groovy
Outdated
Show resolved
Hide resolved
pditommaso
reviewed
Mar 10, 2025
modules/nextflow/src/main/groovy/nextflow/data/cid/CidHistoryRecord.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/data/cid/CidHistoryRecord.groovy
Show resolved
Hide resolved
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
… configurable in workflow data options Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
jorgee
force-pushed
the
cid-store-rev1-fix
branch
from
a8af7eb to
0495bb1
Compare
pditommaso
reviewed
Mar 11, 2025
|
Included in last commit the modification to add the algorithm and mode in the checksum |
|
What about this? |
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Fixed in the last commit. |
jorgee
added a commit
that referenced
this pull request
Mar 12, 2025
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
workflow.data.store.location(e.g. S3)Main changes:
The old
CidFileSystem.basePathis replaced by aCidStoreinstance. It is used byCidPathandCidFileSystemProviderto access metadata. TheCidPath.storePathhas been removed and filePath is storing the path used in the URI as well as the key to use in theCidStore.metaand.data.jsonare private constants in DefaultCidStore property used to store the metadata.The CidHistoryLog interface is provided to decouple the log operations from the underlying storage. The CidHistoryFile is the implementation used in the DefaultCidStore.
The
CidHistoryFilelocation is configurableworkflow.data.store.logLocation. Users can define a remote path but the lock capability is not supported by all providers. If the provider does not support it a warning message is printed.