-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AzBatchService): Allow Azure Batch tasks to be submitted to different pools #5766
Merged
pditommaso
merged 7 commits into
nextflow-io:master
from
adamrtalbot:allow_azure_batch_tasks_to_submit_to_different_pools
Feb 8, 2025
Merged
feat(AzBatchService): Allow Azure Batch tasks to be submitted to different pools #5766
pditommaso
merged 7 commits into
nextflow-io:master
from
adamrtalbot:allow_azure_batch_tasks_to_submit_to_different_pools
Feb 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent pools by including the pool details in getOrCreateJob method Processes could not be submitted to different queues on Azure Batch because the logic looked for an existing job/pool before submitting and didn't check the queue details. This includes the pool ID so that it will now submit to different queues based on user configuration. Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
added a commit
that referenced
this pull request
Feb 9, 2025
…i fast] Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
adamrtalbot
added a commit
to adamrtalbot/nextflow
that referenced
this pull request
Mar 27, 2025
…io#5766) [ci fast] Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: https://nextflow.slack.com/archives/C02T98A23U7/p1738748591243169
Processes could not be submitted to different queues on Azure Batch because the logic looked for an existing job/pool before submitting and didn't check the queue details. This includes the pool ID so that it will now submit to different queues based on user configuration.
You can test it with the following main.nf:
and nextflow.config (with credentials and details redacted):