Skip to content

vendor is now necessary to ship #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2023
Merged

vendor is now necessary to ship #147

merged 2 commits into from
Mar 1, 2023

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Mar 1, 2023 •
edited
Loading

… as it contains autoloading data.

fixes #146

blizzz added 2 commits March 1, 2023 11:18
@blizzz
vendor is now necessary to ship
35b39a7 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
v1.11.1
0d578fa 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
nickvergessen
nickvergessen approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In one app I saw a more specific rule to not bundle dev dependencies when done manually, but can't see it anymore.

@blizzz
Copy link
Member Author

blizzz commented Mar 1, 2023 •
edited
Loading

In one app I saw a more specific rule to not bundle dev dependencies when done manually, but can't see it anymore.

It's a build step https://github.com/nextcloud/workflow_script/blob/master/krankerl.toml#L4

@blizzz blizzz merged commit cb383fd into master Mar 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/build branch March 1, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to 1.11.0: Failed opening required '/PATH/apps/workflow_script/composer/../vendor/autoload.php' in occ
2 participants
@blizzz @nickvergessen