minor: fix fileList default #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azul
force-pushed
the
fix-filelist-default
branch
from
e8c1731 to
2a61078
Compare
|
I ran into this when reusing a component in a different context. |
skjnldsv
approved these changes
Aug 7, 2020
|
/compile amend / |
Props of type array need a factory function for their defaults. Otherwise when reusing the component all might end up with a shared default array. Signed-off-by: Azul <azul@riseup.net> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
fix-filelist-default
branch
from
2a61078 to
61b35e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Props of type array need a factory function for their defaults.
Otherwise when reusing the component
all might end up with a shared default array.