Skip to content

Conversation

@skjnldsv
Copy link
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Apr 16, 2020
@skjnldsv skjnldsv added this to the Nextcloud 19 milestone Apr 16, 2020
@skjnldsv skjnldsv requested a review from v1r0x April 16, 2020 16:34
@skjnldsv skjnldsv self-assigned this Apr 16, 2020
@cypress
Copy link

cypress bot commented Apr 16, 2020



Test summary

164 4 0 0


Run details

Project viewer
Status Failed
Commit 6be0101 ℹ️
Started Apr 20, 2020 9:43 AM
Ended Apr 20, 2020 9:45 AM
Duration 02:00 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 78

View run in Cypress Dashboard ➡️


Failures

images-custom-list-loadmore.spec.js Failed
1 Open custom list of images in viewer with pagination > Does not see a loading animation
sidebar.spec.js Failed
1 Open the sidebar from the viewer and open viewer with sidebar already opened > Does not see a loading animation
images-custom-list.spec.js Failed
1 Open custom images list in viewer > Does not see a loading animation
image.png.spec.js Failed
1 Open image.png in viewer > Does not see a loading animation

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link

@v1r0x v1r0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works fine for files_3d 🐧 👍

@skjnldsv
Copy link
Member Author

@ariselseng can you also check this please? :)

@skjnldsv
Copy link
Member Author

Same for you Julius (when you'll be back), for the Text app :)

Copy link
Member

@ariselseng ariselseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@skjnldsv
Copy link
Member Author

/compile amend /

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the fix/force-apply-mixin branch 6 times, most recently from 4413642 to b0db670 Compare April 20, 2020 09:39
@skjnldsv
Copy link
Member Author

/compile amend /

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 432c311 into master Apr 20, 2020
@skjnldsv skjnldsv deleted the fix/force-apply-mixin branch April 20, 2020 10:19
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 20, 2020

As this is a really big change, I will not backport it, so it will be for 19 and above.
Are you two ok with that?
@juliushaertl ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants