Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Oct 7, 2025

Attempt on making image editing control not hide behind the iPadOS home bar™️

Before After
before Simulator Screenshot - iPad Pro 11-inch (M4) - 2025-10-07 at 20 47 49 after Simulator Screenshot - iPad Pro 11-inch (M4) - 2025-10-07 at 20 48 29

Thanks get redirected to @SystemKeeper

@blizzz blizzz added bug Something isn't working 3. to review Waiting for reviews labels Oct 7, 2025
@blizzz blizzz changed the title fix(ImageEditing): controls might hide behind iPadOS home bar™️ fix(ImageEditing): controls might hide behind iPadOS home bar Oct 7, 2025
@blizzz blizzz requested review from a team, skjnldsv, susnux and szaimen and removed request for a team October 7, 2025 18:54
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@blizzz
Copy link
Member Author

blizzz commented Oct 7, 2025

/backport to stable32

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Oct 7, 2025
@blizzz
Copy link
Member Author

blizzz commented Oct 7, 2025

/backport to stable31

@blizzz
Copy link
Member Author

blizzz commented Oct 7, 2025

/backport to stable30

@blizzz
Copy link
Member Author

blizzz commented Oct 7, 2025

Oh, one question: caniuse states that dvh is supported widely since end of 2022. Is it safe enough? Or should the change be extended with something like https://stackoverflow.com/a/79465288 ?

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/iPadOs-home-bar branch from d0b4fb1 to da4c4aa Compare October 8, 2025 12:16
@szaimen
Copy link
Contributor

szaimen commented Oct 8, 2025

Oh, one question: caniuse states that dvh is supported widely since end of 2022. Is it safe enough? Or should the change be extended with something like https://stackoverflow.com/a/79465288 ?

I'd say this is safe enough 👍

@susnux
Copy link
Contributor

susnux commented Oct 8, 2025

Oh, one question: caniuse states that dvh is supported widely since end of 2022. Is it safe enough?

From the browsers that support it, its fine.

@blizzz blizzz merged commit 186e91a into master Oct 8, 2025
30 checks passed
@blizzz blizzz deleted the fix/iPadOs-home-bar branch October 8, 2025 12:30
@backportbot
Copy link

backportbot bot commented Oct 8, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/2983/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick da4c4aaa

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2983/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Oct 8, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/2983/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick da4c4aaa

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2983/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants