-
Couldn't load subscription status.
- Fork 58
fix(ImageEditing): controls might hide behind iPadOS home bar #2983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
|
/backport to stable32 |
|
/backport to stable31 |
|
/backport to stable30 |
|
Oh, one question: caniuse states that |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
d0b4fb1 to
da4c4aa
Compare
I'd say this is safe enough 👍 |
From the browsers that support it, its fine. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2983/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick da4c4aaa
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2983/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/2983/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick da4c4aaa
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2983/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Attempt on making image editing control not hide behind the iPadOS home bar™️
Thanks get redirected to @SystemKeeper