Skip to content

[Stable28] Preserve sort order #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Altahrim merged 1 commit into from
Apr 18, 2024
Merged

[Stable28] Preserve sort order #2177

Altahrim merged 1 commit into from
Apr 18, 2024

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Feb 26, 2024

backport of #2097

@hamza221 hamza221 added enhancement New feature or request 3. to review Waiting for reviews labels Feb 26, 2024
@hamza221 hamza221 requested a review from skjnldsv February 26, 2024 10:06
@hamza221 hamza221 self-assigned this Feb 26, 2024
@github-actions
Copy link

github-actions bot commented Mar 12, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@hamza221 hamza221 force-pushed the backport/2097/stable28 branch from 48f408b to a66e108 Compare April 15, 2024 14:43
@hamza221
Copy link
Contributor Author

hamza221 commented Apr 15, 2024

Rebased, @skjnldsv can we fit this into next release?

@ChristophWurst ChristophWurst mentioned this pull request Apr 18, 2024
Merged
5 tasks
@hamza221 hamza221 force-pushed the backport/2097/stable28 branch from a66e108 to 9b538bd Compare April 18, 2024 08:26
@Altahrim Altahrim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 18, 2024
szaimen
szaimen approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@hamza221 hamza221 force-pushed the backport/2097/stable28 branch from 9b538bd to 87333a8 Compare April 18, 2024 09:16
@ChristophWurst
Copy link
Member

ChristophWurst commented Apr 18, 2024

/compile amend /

@hamza221 @nextcloud-command
feat: preserve sort order
18d7b96 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Altahrim Altahrim merged commit aa1e46d into stable28 Apr 18, 2024
@Altahrim Altahrim deleted the backport/2097/stable28 branch April 18, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@hamza221 hamza221

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hamza221 @ChristophWurst @szaimen @Altahrim