Skip to content

Create psalm.yml #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2022
Merged

Create psalm.yml #1397

merged 2 commits into from
Oct 4, 2022

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 2, 2022 •
edited
Loading

Fix #1385

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Oct 2, 2022
@skjnldsv skjnldsv self-assigned this Oct 2, 2022
@skjnldsv
Create psalm.yml
fac149a 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 2, 2022 •
edited
Loading 

ERROR: UndefinedClass - lib/Listener/LoadViewerScript.php:50:59 - Class, interface or enum named OCA\Files\Event\LoadAdditionalScriptsEvent does not exist (see https://psalm.dev/019)
		if (!($event instanceof LoadViewer || $event instanceof LoadAdditionalScriptsEvent)) {

I don't get it.
https://github.com/nextcloud/server/blob/ac2bc2384efe3c15ff987b87a7432bc60d545c67/apps/files/lib/Event/LoadAdditionalScriptsEvent.php#L30

@nickvergessen @ChristophWurst do you see something I do not?

@skjnldsv

This comment was marked as resolved.

Sign in to view
@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 2, 2022
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as duplicate.

Sign in to view
@nickvergessen
Update psalm.xml
f70c8db 
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@nickvergessen
Copy link
Member

I don't get it.
https://github.com/nextcloud/server/blob/ac2bc2384efe3c15ff987b87a7432bc60d545c67/apps/files/lib/Event/LoadAdditionalScriptsEvent.php#L30

OCA is not OCP, so it's expected illegal usage.

@skjnldsv skjnldsv merged commit a1539b8 into master Oct 4, 2022
@skjnldsv skjnldsv deleted the feat/psalm branch October 4, 2022 11:32
This was referenced Oct 4, 2022
Merged
Merged
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setup psalm

3 participants

@skjnldsv @nickvergessen