Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to download files with a shortcut #1321

Merged
merged 1 commit into from
Aug 17, 2022
Merged

allow to download files with a shortcut #1321

merged 1 commit into from
Aug 17, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Aug 12, 2022 •
edited
Loading

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-p 8444:443 \
-e VIEWER_BRANCH=enh/noid/shortcut-download \
-e TRUSTED_DOMAIN=10.6.0.1 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added the 2. developing Work in progress label Aug 12, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Aug 12, 2022
@szaimen szaimen force-pushed the enh/noid/shortcut-download branch from 6350de9 to 030c359 Compare August 12, 2022 08:36
@skjnldsv

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 25, Nextcloud 25 beta 2 Aug 12, 2022
@szaimen

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv modified the milestones: Nextcloud 25 beta 2, Nextcloud 25 Aug 15, 2022
@szaimen szaimen added enhancement New feature or request 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 16, 2022
@szaimen szaimen force-pushed the enh/noid/shortcut-download branch from 6d61a4b to b38016f Compare August 16, 2022 17:39
szaimen
szaimen commented Aug 16, 2022
View reviewed changes
src/views/Viewer.vue Outdated Show resolved Hide resolved
@szaimen szaimen marked this pull request as ready for review August 16, 2022 17:41
@nextcloud-command nextcloud-command force-pushed the enh/noid/shortcut-download branch from b38016f to 869fbdc Compare August 16, 2022 17:41
@szaimen szaimen requested review from skjnldsv, jancborchardt, a team, PVince81 and artonge and removed request for a team August 16, 2022 17:41
@szaimen szaimen force-pushed the enh/noid/shortcut-download branch from 869fbdc to a30d3cd Compare August 16, 2022 20:13
@nextcloud-command nextcloud-command force-pushed the enh/noid/shortcut-download branch from a30d3cd to 6ac0e23 Compare August 16, 2022 20:15
@szaimen szaimen force-pushed the enh/noid/shortcut-download branch from 6ac0e23 to 190ae82 Compare August 17, 2022 11:17
@szaimen

This comment was marked as resolved.

Sign in to view
@nextcloud-command nextcloud-command force-pushed the enh/noid/shortcut-download branch from 190ae82 to b0b997a Compare August 17, 2022 11:19
@skjnldsv
Copy link
Member

Ah, I was merging deps to rebase this afterwards, I'll handle it, sorry for the trouble @szaimen 😁

@szaimen @skjnldsv
allow to download files with a shortcut
a727a17 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the enh/noid/shortcut-download branch from b0b997a to a727a17 Compare August 17, 2022 11:24
skjnldsv
skjnldsv approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly and with the editor too! 🚀

@szaimen szaimen merged commit d2187d1 into master Aug 17, 2022
@szaimen szaimen deleted the enh/noid/shortcut-download branch August 17, 2022 11:37
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@szaimen @skjnldsv @jancborchardt