Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable fade-out because of accessbility reasons #1064

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 10, 2021

Fix the follwing point in https://cloud.nextcloud.com/f/4338109

  • Navigation elements should be visible at all times, not fade out

Signed-off-by: szaimen szaimen@e.mail.de

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen added enhancement New feature or request 3. to review Waiting for reviews labels Nov 10, 2021
@szaimen szaimen added this to the Nextcloud 24 milestone Nov 10, 2021
@szaimen
Copy link
Contributor Author

szaimen commented Nov 10, 2021

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, would also be a behavior that @jancborchardt wanted to have for text anyways as tracked in nextcloud/text#82

@szaimen
Copy link
Contributor Author

szaimen commented Nov 11, 2021

/backport ba827b5 to stable22

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Nov 11, 2021
@szaimen
Copy link
Contributor Author

szaimen commented Nov 11, 2021

/backport ba827b5 to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Nov 11, 2021

/backport ba827b5 to stable21

@szaimen szaimen merged commit e7c6af6 into master Nov 11, 2021
@szaimen szaimen deleted the enh/noid/disable-fad-out branch November 11, 2021 11:03
@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Nov 11, 2021

I am sry. Should have waited with the merge for #1065

@szaimen
Copy link
Contributor Author

szaimen commented Nov 11, 2021

/backport ba827b5 to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Nov 11, 2021

/backport ba827b5 to stable22

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen szaimen removed the backport-request Pending backport by the backport-bot label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants