Skip to content

Release Polish #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasReschke merged 2 commits into from
Aug 9, 2016
Merged

Release Polish #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffa18cc
Save next to title
rullzer Aug 9, 2016
d538a41
Slide in/out extra options
rullzer Aug 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion js/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ $(function() {
break;
}
el.html(t('user_saml', text));
nextSibling.toggleClass('hidden');

if (nextSibling.is(":visible")) {
nextSibling.slideUp();
} else {
nextSibling.slideDown();
}
});
});
2 changes: 1 addition & 1 deletion templates/admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/** @var array $_ */
?>
<form id="user-saml" class="section" action="#" method="post">
<h2><?php p($l->t('SAML')); ?></h2>
<h2 class="inlineblock"><?php p($l->t('SAML')); ?></h2>
Copy link
Member

@blizzz blizzz Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the inlineblock for? Other templates don't have it.

Copy link
Member

@MorrisJobke MorrisJobke Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows the save notification to appear on the same level right beside the heading

<div id="user-saml-save-indicator" class="msg success inlineblock" style="display: none;">Saved</div>

<div id="user-saml-settings">
Expand Down