Use client_secret_basic by default, use client_secret_post if supported #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
bug
julien-nc
force-pushed
the
fix/1198/default-token_endpoint_auth_method
branch
from
da4e6cd to
b9f2cae
Compare
…t_secret_post if supported Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
… method in config.php Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/1198/default-token_endpoint_auth_method
branch
from
b9f2cae to
a647192
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1198
As stated in https://openid.net/specs/openid-connect-discovery-1_0.html about
token_endpoint_auth_methods_supported:The new behaviour is:
token_endpoint_auth_methods_supportedis not set in the discovery payload: useclient_secret_basictoken_endpoint_auth_methods_supportedis set and containsclient_secret_post, use ittoken_endpoint_auth_methods_supportedis not set) in config.php with:@hendrik1120 Be aware that you will need to change this default because in your case,
token_endpoint_auth_methods_supportedis not set andclient_secret_postis the only supported method. You can set that value in config.php now (before this change is released), it will be effective with the next release.