fix(extractDownload): Check for presence of zip extension + log Libzip version detected #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
added
enhancement
feature: extraction
…p version detected Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
fix-extractdownload-zip-ext
branch
from
4bcdfde
to
ed1c2b5
Compare
come-nc
approved these changes
Jun 3, 2024
skjnldsv
approved these changes
Jun 3, 2024
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zipis requiredupdater.logto ease later troubleshootingContext: In some older Issues there were mysterious zip issues from some environments. Let's log the versions found to ease debugging.
Mostly did this to test the process PR/CI process in this repo, it's a valid (albeit minor) addition IMO.