Protect against specifying a custom `updatedirectory` located in the installation folder

[tonytonyistony]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• Nextcloud Server is running on 64bit capable CPU, PHP and OS.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

When upgrading from 25.0.2 to 25.0.3, step 3 fails with an error saying cannot create folder...

Message: Could not create folder: /var/www/nextcloud/updater//updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965//updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/u
pdater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1
675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud
-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backup
s/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtzi
w9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updat
er-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/up
dater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-16
75748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-
25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups
/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw
9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/update
r-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/upd
ater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-167
5748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-2
5.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/
nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9
r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater
-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/upda
ter/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675
748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25
.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965

Steps to reproduce

1. Install PHP8.1 and its dependencies
2. Install mariaDB and setup database
3. INstall Apache2 and configure for nextcloud
4. Unzip nextcloud 25.0.2 in www folder and change permissions
5. Browse to GUI and run install script, skip recommended apps
6. Login to Nextcloud, go to settings and set channel to beta
7. Set update directory to "/var/www/nextcloud/updater" in config.php
8. Start update of 25.0.3

Expected behavior

Update completes successfully.

Installation method

Community Manual installation with Archive

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

Last login: Tue Feb  7 05:11:33 2023 from 10.15.20.10
test@test:~$ cat /var/www/nextcloud/updater/updater.log
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] request to updater
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] currentStep()
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] show HTML page
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] current version: 25.0.2 build time: 2022-12-08T11:32:17+00:00 9c791972de9c2561a9b36c1a60e48c25315ecca5
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] getUpdateServerResponse()
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] updaterServer: https://updates.nextcloud.com/updater_server/
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] releaseChannel: beta
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] internal version: 25.0.2.3
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] updateURL: https://updates.nextcloud.com/updater_server/?version=25x0x2x3xxxbetaxx2022-12-08T11%3A32%3A17%2B00%3A00+9c791972de9c2561a9b36c1a60e48c25315ecca5x8x1x2
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] getUpdateServerResponse response: Array
(
    [version] => 25.0.3.2
    [versionstring] => Nextcloud 25.0.3
    [url] => https://download.nextcloud.com/server/releases/nextcloud-25.0.3.zip
    [web] => https://docs.nextcloud.com/server/25/admin_manual/maintenance/upgrade.html
    [changes] => https://updates.nextcloud.com/changelog_server/?version=25.0.3
    [autoupdater] => 1
    [eol] => 0
    [signature] => E1kZNSMlljL+6udQtyjOTvmybAIcY106CvYsnLcCrKydm39+3vCJIU5qQNmZ5Tuq
+rxvU3d+720977yABdlR3AIJAvnmDCO6I7+WlUtYtPefma0PsRb8ujFGZPlg6Srw
OqeOOzuQWcBGyGVtgVoEocqArnuEop2Ff2hQFAGBdTAGaTduTo6120vPuTisWww0
+1nf4rp2DoYa0ODi6w0HDdUBrvlmx2VNMhP4BSqCRmeNWLRxxnbjnFZGfsQXF6aI
JEWp8jY7hTXfHg/hLH9KhrHiXI6cLFcV8VnbSbLH++oNgbqm3rddr1ZSxOSZ1Ytz
cpJAz6JCNAlWFBCs73+VTQ==
)

2023-02-07T05:49:13+0000 hOtWD4Of0f [info] checkForUpdate() Array
(
    [version] => 25.0.3.2
    [versionstring] => Nextcloud 25.0.3
    [url] => https://download.nextcloud.com/server/releases/nextcloud-25.0.3.zip
    [web] => https://docs.nextcloud.com/server/25/admin_manual/maintenance/upgrade.html
    [changes] => https://updates.nextcloud.com/changelog_server/?version=25.0.3
    [autoupdater] => 1
    [eol] => 0
    [signature] => E1kZNSMlljL+6udQtyjOTvmybAIcY106CvYsnLcCrKydm39+3vCJIU5qQNmZ5Tuq
+rxvU3d+720977yABdlR3AIJAvnmDCO6I7+WlUtYtPefma0PsRb8ujFGZPlg6Srw
OqeOOzuQWcBGyGVtgVoEocqArnuEop2Ff2hQFAGBdTAGaTduTo6120vPuTisWww0
+1nf4rp2DoYa0ODi6w0HDdUBrvlmx2VNMhP4BSqCRmeNWLRxxnbjnFZGfsQXF6aI
JEWp8jY7hTXfHg/hLH9KhrHiXI6cLFcV8VnbSbLH++oNgbqm3rddr1ZSxOSZ1Ytz
cpJAz6JCNAlWFBCs73+VTQ==
)

2023-02-07T05:49:13+0000 hOtWD4Of0f [info] getChangelogURL()
2023-02-07T05:49:13+0000 hOtWD4Of0f [info] end of checkForUpdate() Update to Nextcloud 25.0.3 available. (channel: "beta")<br /><span class="light">Following file will be downloaded automatically:</span> <code class="light">https://download.nextcloud.com/server/releases/nextcloud-25.0.3.zip</code><br /><a class="external_link" href="https://nextcloud.com/changelog/#25-0-3" target="_blank" rel="noreferrer noopener">Open changelog ↗</a>
2023-02-07T05:49:16+0000 hTbX9aBrl3 [info] request to updater
2023-02-07T05:49:16+0000 hTbX9aBrl3 [info] currentStep()
2023-02-07T05:49:16+0000 hTbX9aBrl3 [info] POST request for step "1"
2023-02-07T05:49:16+0000 hTbX9aBrl3 [info] startStep("1")
2023-02-07T05:49:16+0000 hTbX9aBrl3 [info] checkForExpectedFilesAndFolders()
2023-02-07T05:49:16+0000 hTbX9aBrl3 [info] end of checkForExpectedFilesAndFolders()
2023-02-07T05:49:16+0000 hTbX9aBrl3 [info] endStep("1")
2023-02-07T05:49:16+0000 NG0EUijznC [info] request to updater
2023-02-07T05:49:16+0000 NG0EUijznC [info] currentStep()
2023-02-07T05:49:16+0000 NG0EUijznC [info] Step 1 is in state "end".
2023-02-07T05:49:16+0000 NG0EUijznC [info] POST request for step "2"
2023-02-07T05:49:17+0000 NG0EUijznC [info] startStep("2")
2023-02-07T05:49:17+0000 NG0EUijznC [info] checkWritePermissions()
2023-02-07T05:49:17+0000 NG0EUijznC [info] end of checkWritePermissions()
2023-02-07T05:49:17+0000 NG0EUijznC [info] endStep("2")
2023-02-07T05:49:17+0000 IzVAAafx4s [info] request to updater
2023-02-07T05:49:17+0000 IzVAAafx4s [info] currentStep()
2023-02-07T05:49:17+0000 IzVAAafx4s [info] Step 2 is in state "end".
2023-02-07T05:49:17+0000 IzVAAafx4s [info] POST request for step "3"
2023-02-07T05:49:17+0000 IzVAAafx4s [info] startStep("3")
2023-02-07T05:49:17+0000 IzVAAafx4s [info] createBackup()
2023-02-07T05:49:17+0000 IzVAAafx4s [info] backup folder location: /var/www/nextcloud/updater//updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/
2023-02-07T05:49:17+0000 IzVAAafx4s [error] POST request failed with other exception
2023-02-07T05:49:17+0000 IzVAAafx4s [error] Exception: Exception
Message: Could not create folder: /var/www/nextcloud/updater//updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957//updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957
Code:0
Trace:
#0 /var/www/nextcloud/updater/index.php(1375): Updater->createBackup()
nextcloud/server#1 {main}
File:/var/www/nextcloud/updater/index.php
Line:436

2023-02-07T05:49:17+0000 IzVAAafx4s [info] rollbackChanges("3")
2023-02-07T05:49:17+0000 IzVAAafx4s [info] unlink .step
2023-02-07T05:49:17+0000 IzVAAafx4s [info] end of  rollbackChanges()
2023-02-07T05:49:25+0000 HI4jRAcDST [info] request to updater
2023-02-07T05:49:25+0000 HI4jRAcDST [info] currentStep()
2023-02-07T05:49:25+0000 HI4jRAcDST [info] POST request for step "3"
2023-02-07T05:49:25+0000 HI4jRAcDST [info] startStep("3")
2023-02-07T05:49:25+0000 HI4jRAcDST [info] createBackup()
2023-02-07T05:49:25+0000 HI4jRAcDST [info] backup folder location: /var/www/nextcloud/updater//updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/
2023-02-07T05:49:25+0000 HI4jRAcDST [error] POST request failed with other exception
2023-02-07T05:49:25+0000 HI4jRAcDST [error] Exception: Exception
Message: Could not create folder: /var/www/nextcloud/updater//updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965//updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965/updater/updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748965
Code:0
Trace:
#0 /var/www/nextcloud/updater/index.php(1375): Updater->createBackup()
nextcloud/server#1 {main}
File:/var/www/nextcloud/updater/index.php
Line:436

2023-02-07T05:49:25+0000 HI4jRAcDST [info] rollbackChanges("3")
2023-02-07T05:49:25+0000 HI4jRAcDST [info] unlink .step
2023-02-07T05:49:25+0000 HI4jRAcDST [info] end of  rollbackChanges()
test@test:~$

List of activated Apps

None

Nextcloud Signing status

No errors have been found

Nextcloud Logs

test@test:~$ sudo cat /var/www/nextcloud/data/nextcloud.log | jq
[sudo] password for test:
{
  "reqId": "Gn64osIKtbPMp0chg2Ly",
  "level": 2,
  "time": "2023-02-07T05:43:53+00:00",
  "remoteAddr": "10.15.20.49",
  "user": "--",
  "app": "no app in context",
  "method": "GET",
  "url": "/",
  "message": "Could not detect any host in http:///data/htaccesstest.txt",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "",
  "data": []
}
{
  "reqId": "Gn64osIKtbPMp0chg2Ly",
  "level": 2,
  "time": "2023-02-07T05:43:53+00:00",
  "remoteAddr": "10.15.20.49",
  "user": "--",
  "app": "no app in context",
  "method": "GET",
  "url": "/",
  "message": "Could not detect any host in https:///data/htaccesstest.txt",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "",
  "data": []
}
{
  "reqId": "vgxcPntpHt1c2jXQalXg",
  "level": 2,
  "time": "2023-02-07T05:44:39+00:00",
  "remoteAddr": "10.15.20.49",
  "user": "--",
  "app": "no app in context",
  "method": "POST",
  "url": "/index.php",
  "message": "Could not detect any host in http:///data/htaccesstest.txt",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "",
  "data": []
}
{
  "reqId": "vgxcPntpHt1c2jXQalXg",
  "level": 2,
  "time": "2023-02-07T05:44:39+00:00",
  "remoteAddr": "10.15.20.49",
  "user": "--",
  "app": "no app in context",
  "method": "POST",
  "url": "/index.php",
  "message": "Could not detect any host in https:///data/htaccesstest.txt",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "",
  "data": []
}
{
  "reqId": "vgxcPntpHt1c2jXQalXg",
  "level": 3,
  "time": "2023-02-07T05:45:59+00:00",
  "remoteAddr": "10.15.20.49",
  "user": "admin",
  "app": "PHP",
  "method": "POST",
  "url": "/index.php",
  "message": "exif_read_data(): File not supported at /var/www/nextcloud/lib/private/Metadata/Provider/ExifProvider.php#59",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "25.0.2.3",
  "exception": {
    "Exception": "Error",
    "Message": "exif_read_data(): File not supported at /var/www/nextcloud/lib/private/Metadata/Provider/ExifProvider.php#59",
    "Code": 0,
    "Trace": [
      {
        "function": "onError",
        "class": "OC\\Log\\ErrorHandler",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Metadata/Provider/ExifProvider.php",
        "line": 59,
        "function": "exif_read_data"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Metadata/MetadataManager.php",
        "line": 68,
        "function": "execute",
        "class": "OC\\Metadata\\Provider\\ExifProvider",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Metadata/FileEventListener.php",
        "line": 101,
        "function": "generateMetadata",
        "class": "OC\\Metadata\\MetadataManager",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/EventDispatcher/ServiceEventListener.php",
        "line": 87,
        "function": "handle",
        "class": "OC\\Metadata\\FileEventListener",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
        "line": 251,
        "function": "__invoke",
        "class": "OC\\EventDispatcher\\ServiceEventListener",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
        "line": 73,
        "function": "callListeners",
        "class": "Symfony\\Component\\EventDispatcher\\EventDispatcher",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/EventDispatcher/EventDispatcher.php",
        "line": 88,
        "function": "dispatch",
        "class": "Symfony\\Component\\EventDispatcher\\EventDispatcher",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/EventDispatcher/EventDispatcher.php",
        "line": 100,
        "function": "dispatch",
        "class": "OC\\EventDispatcher\\EventDispatcher",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Files/Node/HookConnector.php",
        "line": 118,
        "function": "dispatchTyped",
        "class": "OC\\EventDispatcher\\EventDispatcher",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/legacy/OC_Hook.php",
        "line": 106,
        "function": "postWrite",
        "class": "OC\\Files\\Node\\HookConnector",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Files/View.php",
        "line": 641,
        "function": "emit",
        "class": "OC_Hook",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Files/View.php",
        "line": 692,
        "function": "emit_file_hooks_post",
        "class": "OC\\Files\\View",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Files/Node/File.php",
        "line": 71,
        "function": "file_put_contents",
        "class": "OC\\Files\\View",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/legacy/OC_Util.php",
        "line": 257,
        "function": "putContent",
        "class": "OC\\Files\\Node\\File",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/legacy/OC_Util.php",
        "line": 216,
        "function": "copyr",
        "class": "OC_Util",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/private/User/Session.php",
        "line": 553,
        "function": "copySkeleton",
        "class": "OC_Util",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/private/User/Session.php",
        "line": 403,
        "function": "prepareUserLogin",
        "class": "OC\\User\\Session",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/User/Session.php",
        "line": 616,
        "function": "completeLogin",
        "class": "OC\\User\\Session",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/lib/private/User/Session.php",
        "line": 355,
        "function": "loginWithPassword",
        "class": "OC\\User\\Session",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/lib/private/Setup.php",
        "line": 433,
        "function": "login",
        "class": "OC\\User\\Session",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/core/Controller/SetupController.php",
        "line": 69,
        "function": "install",
        "class": "OC\\Setup",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/lib/base.php",
        "line": 980,
        "function": "run",
        "class": "OC\\Core\\Controller\\SetupController",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/index.php",
        "line": 36,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "/var/www/nextcloud/lib/private/Log/ErrorHandler.php",
    "Line": 92,
    "CustomMessage": "--"
  }
}
test@test:~$

Additional info

Firefox Browser

[Silverwhitewolf]

recreating the above scenario and declaring the 'updatedirectory' in the config.php to point at /var/www/nextcloud/updater/ willd cause this exact problem. what I infer is happening is updater.phar is not ignoring the update directory location and when backing up it start backing up the backup and ect. a loop till the hard drive is complete full then errors out. changing it outside would likely fix this or updating updater.phar to ignore w/e directory is created in updatedirectory var in config.
I had this exact problem and was replicating Said Example above. in my instance i Declared my data directory on my mount. ( which also declares the update to be put in my mount directory. to prevent this i unknowingly declared the updatedirectory being the /var/www/nextcloud/updater folder(seemed logical). updating then cause this exact situation. much testing come to find out if you declare the /var/www/nextcloud/data folder(default for update dir) it worked fine.

TLDR Updater.phar needs to be updated to ignore the update folder regardless of where it is located.

[tonytonyistony]

The activity in this git is quite concerning. Is Nextcloud on its way out? Or do we need to open support contracts to get any feedback from any active developers?

[joshtrichards]

7. Set update directory to "/var/www/nextcloud/updater" in config.php
   [...]
   2023-02-07T05:49:17+0000 IzVAAafx4s [info] backup folder location: /var/www/nextcloud/updater//updater-oc7vwtziw9r4/backups/nextcloud-25.0.2.3-1675748957/
   [...]

Indeed. Setting updatedirectory to /var/www/nextcloud/updater/ (which is presumably within your Nextcloud installation directory) would cause this. The default value for updatedirectory -- perfectly reasonable for most people - is to use the configured datadirectory (which is already automatically excluded by the backup step).

If you do set a updatedirectory, it needs to be completely outside the Nextcloud installation folder hierarchy.

We should fix the docs (config.sample.php + Admin Manual):

• PENDING: docs(config.sample.php): Warn that updatedirectory will break updates if set to a value within the installation folder server#44138

We should also consider adding any custom configured updatedirectory to our exclusion list in createBackup(). Probably here:

updater/lib/Updater.php

Lines 404 to 407 in b0d2bc6

	$excludedElements = [
	'.rnd',
	'.well-known',
	'data',

...by adding the value of $backupFolderLocation (set immediately below there) or the return value ofgetUpdateDirectoryLocation() to the array.