Add User-Agent header to Wikimedia image requests#167
Closed
notapirate wants to merge 2 commits intonextcloud:masterfrom
Closed
Add User-Agent header to Wikimedia image requests#167notapirate wants to merge 2 commits intonextcloud:masterfrom
notapirate wants to merge 2 commits intonextcloud:masterfrom
Conversation
The function getUserAgent uses the app informations to construct the string "unsplash/<version> (<website>; <contact>)" to be used as user agent for provider requests. Signed-off-by: notapirate <notapirate@users.noreply.github.com>
Signed-off-by: notapirate <notapirate@users.noreply.github.com>
Author
|
This is now obsolete, PR #168 fixes this problem too, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create function getUserAgent to construct a user agent string and use it for Wikimedia requests as required by Wikimedia.
The string is formatted as suggested by Wikimedias User Agent Policy, see https://foundation.wikimedia.org/wiki/Policy:Wikimedia_Foundation_User-Agent_Policy.
Closes #166