Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): Aligned spelling and adapted grammar #1585

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Conversation

rakekniven
Copy link
Member

Reported at Transifex.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@191b9cc). Learn more about missing BASE report.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1585   +/-   ##
=========================================
  Coverage          ?   42.50%           
  Complexity        ?      102           
=========================================
  Files             ?       19           
  Lines             ?      327           
  Branches          ?        0           
=========================================
  Hits              ?      139           
  Misses            ?      188           
  Partials          ?        0           
Flag Coverage Δ
unittests 42.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@miaulalala
Copy link
Contributor

Linter isn't happy, can you run composer run cs:fix please?

@rakekniven
Copy link
Member Author

I am using Transifex and GitHub only in the browser.
Have no development setup available.

Can you do this?

Thank you.

@miaulalala
Copy link
Contributor

Ah nvm it's the matrix. Needs a 3rd party lib update.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@rakekniven rakekniven changed the title chore(i18n); Aligned spelling and adapted grammar chore(i18n): Aligned spelling and adapted grammar Dec 17, 2024
@st3iny st3iny merged commit 6311b14 into master Dec 28, 2024
22 of 23 checks passed
@st3iny st3iny deleted the rakekniven-patch-1 branch December 28, 2024 12:50
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants