fix(sync): Reset document sessions on upgrade #7783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in synchronizing the document state might have resulted in a Yjs document state with missing steps being persisted into the Ydoc that we store on the server. If no client that had the missing step did an autosave afterwards, future sync session members will never recover from this situation. We implemented several improvements recently that should result in less out-of-sync situations where a step becomes missing. To start with fresh editing sessions and not carry on with possibly unrecoverable document states, let's reset all editing sessions with the next app update. See #7692 for further context. Signed-off-by: Jonas <jonas@freesources.org>
|
/backport to stable32 |
|
/backport to stable31 |
|
We already discussed this and the code changes are minimal. Would like to wait for a review from @juliusknorr |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7783 +/- ##
=======================================
Coverage 60.19% 60.19%
=======================================
Files 502 502
Lines 38561 38561
Branches 1135 1135
=======================================
Hits 23210 23210
Misses 15245 15245
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
approved these changes
Oct 15, 2025
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in synchronizing the document state might have resulted in a Yjs document state with missing steps being persisted into the Ydoc that we store on the server. If no client that had the missing step did an autosave afterwards, future sync session members will never recover from this situation.
We implemented several improvements recently that should result in less out-of-sync situations where a step becomes missing. To start with fresh editing sessions and not carry on with possibly unrecoverable document states, let's reset all editing sessions with the next app update.
See #7692 for further context.
Resolved #7692
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)