Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Jun 19, 2025

Fixes errors during test runs such as https://github.com/nextcloud/text/actions/runs/15742170977/job/44369984600

Bildschirmfoto vom 2025-06-19 09-45-46

Use vitests test.extend to make sure destroy is also called if the test fails.

We create editors without destroying them in a lot more tests. I briefly tried to fix that with a editorTest fixture everywhere - but it's just too much work right now. I've only seen these ones error out during tests. So let's fix them when they throw exceptions one by one...

@max-nextcloud max-nextcloud requested a review from mejo- as a code owner June 19, 2025 07:49
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.33%. Comparing base (cdcb338) to head (2837b26).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7316   +/-   ##
=======================================
  Coverage   52.32%   52.33%           
=======================================
  Files         482      482           
  Lines       42038    42038           
  Branches     1047     1049    +2     
=======================================
+ Hits        21998    22000    +2     
+ Misses      19937    19935    -2     
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud requested a review from a team June 19, 2025 07:58
@max-nextcloud max-nextcloud force-pushed the fix/tests-with-dangling-editor branch from 9d6f929 to 9a25a2b Compare June 20, 2025 13:18
@max-nextcloud max-nextcloud enabled auto-merge June 20, 2025 13:19
@max-nextcloud max-nextcloud force-pushed the fix/tests-with-dangling-editor branch from 9a25a2b to e379001 Compare June 20, 2025 14:23
Fixes errors during test runs such as https://github.com/nextcloud/text/actions/runs/15742170977/job/44369984600

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the fix/tests-with-dangling-editor branch from e379001 to 2837b26 Compare June 21, 2025 18:27
@max-nextcloud max-nextcloud merged commit 76f00d7 into main Jun 21, 2025
66 checks passed
@max-nextcloud max-nextcloud deleted the fix/tests-with-dangling-editor branch June 21, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants