Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented May 19, 2025

Backport of PR #7183

@backportbot backportbot bot requested a review from max-nextcloud May 19, 2025 07:17
@backportbot backportbot bot added this to the Nextcloud 30.0.12 milestone May 19, 2025
@mejo- mejo- changed the title [stable30] [stable31] Disable attachment upload on federated shares [stable30] Disable attachment upload on federated shares May 19, 2025
@mejo- mejo- force-pushed the backport/7183/stable30 branch from 236af19 to 4732e32 Compare May 19, 2025 10:26
@mejo-
Copy link
Member

mejo- commented May 19, 2025

@max-nextcloud it seems like the node test are failing because stable30 was not ported to vitest yet.

@max-nextcloud
Copy link
Collaborator

it seems like the node test are failing because stable30 was not ported to vitest yet.

That makes sense - let's dump the tests then. This was helpful for development and to prevent regressions. But any new code that passes these tests on stable31 is very unlikely to break this when backported.

Files without an owner such as federated shares

cannot receive attachments

as the attachment would need to be stored in the owners user folder.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the backport/7183/stable30 branch from 4732e32 to 664edb8 Compare May 20, 2025 10:11
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.68%. Comparing base (ad0a087) to head (664edb8).
Report is 4 commits behind head on stable30.

Additional details and impacted files
@@            Coverage Diff            @@
##           stable30    #7235   +/-   ##
=========================================
  Coverage     53.68%   53.68%           
=========================================
  Files           116      116           
  Lines          2578     2578           
  Branches        527      527           
=========================================
  Hits           1384     1384           
  Misses         1066     1066           
  Partials        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud merged commit a023795 into stable30 May 20, 2025
66 checks passed
@max-nextcloud max-nextcloud deleted the backport/7183/stable30 branch May 20, 2025 14:25
@nextcloud-bot nextcloud-bot mentioned this pull request Jun 4, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants