Skip to content

feat: Implement event so collectives can inject custom notification messages #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

feat: Implement event so collectives can inject custom notification messages #6923

merged 1 commit into from
May 13, 2025

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 27, 2025 •
edited
Loading

Base pr for nextcloud/collectives#1675 to allow the collectives app to set their own notification details for mentions within a collective.

@juliusknorr juliusknorr mentioned this pull request Feb 27, 2025
Merged
4 tasks
@juliusknorr juliusknorr added enhancement New feature or request 3. to review labels Feb 27, 2025
@juliusknorr juliusknorr requested a review from a team February 27, 2025 16:05
@juliusknorr juliusknorr mentioned this pull request Feb 27, 2025
Closed
max-nextcloud
max-nextcloud approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. Makes sense to have this. did not test it though.

... which also reminds me that it might be nice to have tests for this as it will be hard to notice if it breaks.

@juliusknorr @mejo-
feat: Implement event so collectives can inject custom notification m…
df8fe6e 
…essages

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@mejo- mejo- force-pushed the feat/custom-mention branch from 04283a2 to df8fe6e Compare May 13, 2025 11:21
mejo-
mejo- approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works well! I guess the easiest would be to test this inside Collectives tbh.

@mejo- mejo- merged commit e88ee52 into main May 13, 2025
67 checks passed
@mejo- mejo- deleted the feat/custom-mention branch May 13, 2025 11:38
@mejo-
Copy link
Member

mejo- commented May 14, 2025

/backport to stable31

@backportbot backportbot bot mentioned this pull request May 14, 2025
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo- mejo- mejo- approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

Assignees

No one assigned

Labels

3. to review enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @mejo- @max-nextcloud