Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(sync): reuse open connection #6061

Merged
merged 1 commit into from
Jul 19, 2024

Commits on Jul 19, 2024

  1. fix(sync): reuse open connection

    Do not attempt to create a new connection
    if there already is one and it is not closed.
    
    If no messages are received for 30 seconds
    yjs will open a new websocket.
    
    Since we do not close the connection anymore from the websocket polyfill
    we also do not need to open it.
    
    If the network connection has gone down
    creating a new connection will fail anyway.
    
    Once it comes back we will know if the session is still valid.
    Then we can either continue using it or reconnect.
    
    This is part of #6050.
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0ec22ea View commit details
    Browse the repository at this point in the history