Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: get folder node directly from dav node instead of getting it by id #5961

Merged
merged 1 commit into from
Jun 27, 2024
Merged

perf: get folder node directly from dav node instead of getting it by id #5961

merged 1 commit into from
Jun 27, 2024

Conversation

icewind1991
Copy link
Member

📝 Summary

Should significantly improve the performance of the dav plugin

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@icewind1991
perf: get folder node directly from dav node instead of getting it by id
1fdd5d3 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added this to the Nextcloud 30 milestone Jun 27, 2024
@juliushaertl
Copy link
Member

Great catch, thanks

@juliushaertl juliushaertl merged commit d5a5896 into main Jun 27, 2024
61 of 63 checks passed
@juliushaertl juliushaertl deleted the perf-workspace-dav-node branch June 27, 2024 15:56
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
3. to review performance 🚀
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
2 participants
@icewind1991 @juliushaertl