Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LinkBubble): Don't open bubble at initialization and on remote changes #5924

Merged
merged 7 commits into from
Jun 25, 2024
Merged

fix(LinkBubble): Don't open bubble at initialization and on remote changes #5924

merged 7 commits into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. fix(LinkBubble): Don't open bubble when initializing the editor 

    Fixes: #5855
Fixes: nextcloud/collectives#1296

Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e784bd1 View commit details
    Browse the repository at this point in the history

  2. fix(LinkBubble): Don't open bubble on changes by other session members 

    Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    89dc1d5 View commit details
    Browse the repository at this point in the history

  3. test(cypress): Fix initial content undo test 

    Undo button should be disabled after initial content got loaded and only
get enabled after typing something.

Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    16d33f4 View commit details
    Browse the repository at this point in the history

  4. fix(LinkBubble): Fix race condition between hide and update 

    Hide was called with a timeout of 100ms, while update was not. This
could lead to a race condition and flaky link bubble behaviour.

Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    96b9467 View commit details
    Browse the repository at this point in the history

  5. chore(LinkBubble): remove superfluous checks 

    `active` object from prosemirror state and oldState are never similar
anyway.

Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3550815 View commit details
    Browse the repository at this point in the history

  6. fix(LinkBubble): Hide link bubble when removing a link 

    Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a2f9f65 View commit details
    Browse the repository at this point in the history

  7. test(cypress): Remove superfluous cy.get() 

    Should make the workspace link bubble test less flaky.

Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    bd1c2e2 View commit details
    Browse the repository at this point in the history