Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable callouts button when all callout variants are disabled #5720

Merged

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Apr 22, 2024

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing Jest and Cypress component tests are not related I think.

Cypress is failing for an interesting reason:
Test the rich text editor menu bar -- word count -- empty file (failed)

In the word count tests the remain menu cannot be opened as all actions in it are not availabe. So in a way your changes are working - you will need to account for the special case of the word count entry though.

@luka-nextcloud luka-nextcloud force-pushed the disable-callouts-button-when-all-variants-disabled branch from 26cdebe to b64d837 Compare April 24, 2024 12:25
luka-nextcloud and others added 3 commits April 30, 2024 13:37
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Check if there is any child that is enabled.

This is somewhat simpler than storing an array of the disabled children
and comparing it's length to the length of the array of non-seperator children.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the disable-callouts-button-when-all-variants-disabled branch from daab3ce to cd1641b Compare April 30, 2024 11:38
@luka-nextcloud luka-nextcloud merged commit 8044a11 into main Apr 30, 2024
63 checks passed
@luka-nextcloud luka-nextcloud deleted the disable-callouts-button-when-all-variants-disabled branch April 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark callout button as disabled when all callout variants are disabled
2 participants