Fix/5522 no link preview toggle for anchor links #5544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <max@nextcloud.com>
This makes the check for `can().setTextSelection()` a lot easier as we do not need to change the selection to be within the link. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/5522-no-link-preview-toggle-for-anchor-links
branch
from
fca964c to
2f19e41
Compare
Collaborator
Author
|
design team proposed to always show the menu but only allow toggling when possible - however this would apply to all paragraphs now - seems a little to much right now. So only showing 3 dot when possible to toggle for now. |
juliusknorr
approved these changes
Mar 21, 2024
juliusknorr
deleted the
fix/5522-no-link-preview-toggle-for-anchor-links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)