Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 403 on close #4824

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix 403 on close #4824

merged 2 commits into from
Oct 30, 2023

Conversation

max-nextcloud
Copy link
Collaborator

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

mejo-
mejo- reviewed Sep 26, 2023
View reviewed changes
src/services/SessionApi.js Outdated Show resolved Hide resolved
src/services/WebSocketPolyfill.js Show resolved Hide resolved
@max-nextcloud
Copy link
Collaborator Author

/backport to stable27

@max-nextcloud
Copy link
Collaborator Author

/backport to stable26

@max-nextcloud
fix(api): prevent sending requests with closed session.
d17bc9a 
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
fix(api): send remaining steps before closing connection
d899714 
y.js will send a last awareness update when closing the websocket.
Try to get this out before closing the sync service connection.

Signed-off-by: Max <max@nextcloud.com>
@mejo- mejo- merged commit 8f14961 into main Oct 30, 2023
33 of 35 checks passed
@mejo- mejo- deleted the fix/403-on-close branch October 30, 2023 21:19
@juliushaertl
Copy link
Member

/backport to stable27

@juliushaertl
Copy link
Member

/backport to stable26

@mejo-
Copy link
Member

mejo- commented Nov 7, 2023

/backport d17bc9a,d89971462e6233fa0d24be39bfa903c79f6cb6d2 to stable27

@mejo- mejo- mentioned this pull request Nov 7, 2023
Merged
@joshtrichards joshtrichards mentioned this pull request Dec 1, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@mejo- mejo- mejo- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Y.js fails to disconnect because session is already closed
3 participants
@max-nextcloud @juliushaertl @mejo-