[stable25] fix: reconnect - reload main container #3635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
/compile |
Introduce `hasEditor` as reactive data to dynamically reload the MainContainer. $editor is not reactive. Once the MainContainer was rendered it stayed - even when the connection expired. The child components of MainContainer would still have the old $editor value. Fixes #3374. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
max-nextcloud
force-pushed
the
backport/3627/stable25
branch
from
4c8e1b9 to
dc3dc19
Compare
juliusknorr
changed the title
juliusknorr
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
hasEditoras reactive data to dynamically reload the MainContainer.$editor is not reactive.
Once the MainContainer was rendered it stayed - even when the connection expired. The child components of MainContainer would still have the old $editor value.
Fixes #3374.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)