Set IUserSession user in SessionController if available #3390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
max-nextcloud
approved these changes
Nov 9, 2022
fixes #2821 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
max-nextcloud
force-pushed
the
fix/2821
branch
from
6aacf0c to
b9df729
Compare
|
/compile |
|
stupid me... this one does not need to be compiled. |
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
This was referenced Nov 9, 2022
|
I'm actually wondering why we have a separate DirectSessionController, it doesn't seem to be used anywhere. |
|
Yes, seems like some dead code right from the initial pull request #372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2821
Summary
I thought #3356 would fix #2821 but after testing again it appears it didn't because I edited the wrong file. The problem was that if you are the user that edits you of course shouldn't get any notification at all, which is harder to verify than getting a notification :'D
That said, I believe #3356 is still a good change.