[stable25] Disable rich workspace rendering when view is not visible #3377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
juliusknorr,
luka-nextcloud,
max-nextcloud,
mejo- and
vinicius73
|
/compile |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
This depends on #3323 getting merged. |
ahh.. that's even better. I'll revert my fix. |
max-nextcloud
force-pushed
the
backport/3349/stable25
branch
from
316bf2c to
ddcbda3
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
* `#workspace` is not found on the recent pages view at all - so need to combine selectors * allow tests to pass in retries by using a consistent path name. Signed-off-by: max-nextcloud <max@nextcloud.com>
max-nextcloud
force-pushed
the
backport/3349/stable25
branch
from
ddcbda3 to
755939c
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
max-nextcloud
approved these changes
Nov 7, 2022
|
failing test seems unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3349