text: fix cypress selector to find the right image#2603
Merged
Conversation
`get().filter()` might not take into account elements that did not exist in the dom yet when the `get` part was fired. `.filter()` would then wait for the elements that already existed during `.get()` to contain the newly created image. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
test/fix-cypress-selector
branch
from
8393ecc to
ffba707
Compare
Collaborator
Author
|
/backport to stable24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get().filter()might not take into account elementsthat did not exist in the dom yet when the
getpart was fired..filter()would then wait for the elements that already existedduring
.get()to contain the newly created image.Signed-off-by: Max max@nextcloud.com