Skip to content

Fix cypress tests on stable24 #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-nc merged 3 commits into from
Apr 25, 2022
Merged

Fix cypress tests on stable24 #2336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d91091b
Revert "adapt cypress login command to small change in 25"
mejo- Apr 25, 2022
a404267
Use stable24 branch in cypress tests
mejo- Apr 25, 2022
269c064
backport click on menu items with narrow page
Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cypress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
# containers: [1, 2, 3]
php-versions: [ '7.4' ]
databases: [ 'sqlite' ]
server-versions: [ 'master' ]
server-versions: [ 'stable24' ]

steps:
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
4 changes: 2 additions & 2 deletions cypress/integration/workspace.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ describe('Workspace', function() {
['strike', 's'],
].forEach(([button, tag]) => {
menuButton(button)
.click()
.click({ force: true })
.should('have.class', 'is-active')
cy.get(`.ProseMirror ${tag}`).should('contain', 'Format me')
menuButton(button)
.click()
.click({ force: true })
.should('not.have.class', 'is-active')
})
})
Expand Down
2 changes: 1 addition & 1 deletion cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Cypress.Commands.add('login', (user, password, { route, onBeforeLoad } = {}) =>
cy.visit(route)
cy.get('input[name=user]').type(user)
cy.get('input[name=password]').type(password)
cy.get('.submit-wrapper input[type=submit]').click()
cy.get('#submit-wrapper input[type=submit]').click()
cy.url().should('include', route)
})
// in case the session already existed but we are on a different route...
Expand Down