Skip to content

[stable22] fix: 2020 let heading menu overflow workspace #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2022
Merged

[stable22] fix: 2020 let heading menu overflow workspace #2113

merged 3 commits into from
Jan 19, 2022

Conversation

@max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Jan 19, 2022 •
edited by juliusknorr
Loading

Summary

azul and others added 3 commits January 19, 2022 09:03
@azul @max-nextcloud
fix: 2020 let heading menu overflow workspace
be00754 
* roll back parts of #1903 that broke it again.
* Calculate top of menububble based on scrollHeight of content-wrapper.
* Always display menububble below selected line.
  This will make it less likely to conflict with the menubar
  or mobile copy and paste toolbars.
* Add cypress tests for the workspace.

Signed-off-by: Azul <azul@riseup.net>
@azul @max-nextcloud
hand the content wrapper to the menububble explicitly
0b09a9c 
Signed-off-by: Azul <azul@riseup.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@max-nextcloud
fix: vue warning about invalid prop type
b1b9818 
* Fixes #2103.
* Targets master.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
Copy link
Collaborator Author

cypress is still failing because of the regression in server.
Need to wait for nextcloud/server#30752 and then run the tests again.

@max-nextcloud max-nextcloud added this to the Nextcloud 22.2.4 milestone Jan 19, 2022
@max-nextcloud max-nextcloud merged commit b46f6fc into stable22 Jan 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/stable22/2020 branch January 19, 2022 10:59
@skjnldsv skjnldsv mentioned this pull request Jan 20, 2022
Merged
8 tasks
@mejo- mejo- mentioned this pull request Jan 24, 2022
Closed
@skjnldsv skjnldsv mentioned this pull request Jan 25, 2022
Merged
5 tasks
@juliusknorr juliusknorr changed the title Backport/stable22/2020 [stable22] fix: 2020 let heading menu overflow workspace Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo- mejo- mejo- approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 22.2.4

Development

Successfully merging this pull request may close these issues.

4 participants

@max-nextcloud @mejo- @azul