make collabora on top of text idle message #1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Sep 14, 2021
src/views/RichWorkspace.vue
Outdated
| text-align: left; | ||
| max-height: 0; | ||
| transition: max-height 0.5s cubic-bezier(0, 1, 0, 1); | ||
| z-index: 110; |
There was a problem hiding this comment.
The cypress test failure seems expected due to this z-index being larger than the one of the file creation menu which would cause some overlapping like this:
In addition it might be good to add a position: relative; here as well to make sure the z-index always applies.
juliusknorr
requested changes
Sep 14, 2021
|
@luka-nextcloud Could you check that again for the comment above? |
juliusknorr
approved these changes
Oct 20, 2021
|
Needs a rebase and build with latest bundles 😉 |
|
/rebase |
Signed-off-by: Luka Trovic <luka@nextcloud.com>
juliusknorr
force-pushed
the
fix-text-idle-message-overlap-collabora
branch
from
052b4c4 to
d59cc78
Compare
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
25 tasks
max-nextcloud
pushed a commit
that referenced
this pull request
Jan 13, 2022
* Backports: #1860 * Target version: stable22 Signed-off-by: Luka Trovic <luka@nextcloud.com>
max-nextcloud
pushed a commit
that referenced
this pull request
Jan 13, 2022
* Backports: #1860 * Target version: stable22 Signed-off-by: Luka Trovic <luka@nextcloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary