Use to correct cache to obtain version info #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok. so this actually does boom... |
|
@juliushaertl I guess we either need to improve the caching logic or rip it out in this case. Because right now it does nothing ;) |
juliushaertl
force-pushed
the
fix/use_correct_cache
branch
from
ce4fece
to
674573f
Compare
|
I moved the cache handling entirely to the DocumentService now as there is no need to have that in two places. It was basically broken because we returned to early and missed the document and session information. |
juliushaertl
approved these changes
Nov 18, 2020
|
Doesn't save much indeed, but also doesn't hurt to have a cache for that case. |
juliushaertl
force-pushed
the
fix/use_correct_cache
branch
from
674573f
to
1445499
Compare
* The documentservice writes to the text prefix. Not the textSession prefix. Hence we never found any of the cache entries. Thus always doing all the work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
juliushaertl
force-pushed
the
fix/use_correct_cache
branch
from
1445499
to
b4963f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefix. Hence we never found any of the cache entries. Thus always
doing all the work.