LaTeX formula modal is cut off

[juliusknorr]

When testing the modal seems to have an issue with not taking up the full height of the textarea, but I'm unsure if that is a component issue or could be addressed here as well. Would be fine to track as a follow up for polishing:

Originally posted by @juliusknorr in #7957 (review)

[moodyjmz]

I was having a little look at this, I notice the docs here

https://nextcloud-vue-components.netlify.app/#/Components/NcDialog?id=ncdialog-1

Seems to have a bug:

Where the loading example doesn't close the dialog.

The dialog doesn't appear to support larger forms, saying 'It is also possible to use the dialog for small forms.'.

Maybe NcModal needs to be extended into a new component to support larger forms, or NcDialog needs to be modified to provide that feature.

I would suggest that extend the dialog to support larger forms might be the most straightforward as it already has the button functionality and the changes would, hopefully, be styling only.

[juliusknorr]

Thanks for checking again. I think this is more a problem of the example code where the dialog does not close. The first example also does work properly in that regard.

What I found weired that using a plain textarea does work properly there, so maybe it is some of the NcTextArea specific styling that prevents the height adjusting?

[moodyjmz]

Interesting. I had a look there, and it led me to here
https://github.com/nextcloud-libraries/nextcloud-vue/blob/main/src/components/NcDialog/NcDialog.vue

Here, I noticed that if I set size to 'full', then the text area is much bigger.

I notice in the browser page:

.textarea__main-wrapper[data-v-11ea0e4b] {
    height: calc(var(--default-clickable-area) * 2);

which is: --default-clickable-area: 34px;.

https://github.com/nextcloud-libraries/nextcloud-vue/blob/main/src/components/NcTextArea/NcTextArea.vue#L303

Turning the height rule off off sets the height to the textarea. Not sure of the fix though, but that appears to be the cause.