fix: adjust to new datepicker api #2884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
bug
design
dependencies
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/2883/datepicker-migration
branch
from
3b3d1a6 to
43c1d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the usage of
NcDateTimePickerto the new API changed with nextcloud-libraries/nextcloud-vue#6651.In order for the styling to be usable again, nextcloud-libraries/nextcloud-vue#7051 needs to be merged. Also, fixing nextcloud-libraries/nextcloud-vue#7050 would be helpful, as the style is flawed when the picker is attached to body (which is necessary here).
Going to merge this anyway already, since it doesn't get worse than now and further fixes need to be done upstream.