fix(app): show window on activate on macOS - #852
Merged
Conversation
Antreesy
reviewed
Oct 28, 2024
| app.on('activate', () => { | ||
| if (BrowserWindow.getAllWindows().length === 0) { | ||
| mainWindow = createMainWindow() | ||
| mainWindow.show() |
Contributor
There was a problem hiding this comment.
Would it make sense to wrap mainWindow into once listener, like in other places? Or it won't work because of app.on / MacOS specific handling?
Suggested change
| mainWindow.show() | |
| mainWindow.once('ready-to-show', () => mainWindow.show())) |
Member
|
@Ivansss @SystemKeeper does this match the MacOS user expectation? |
Member
Yes, clicking on the Dock icon and create and show the window again would match user expectations. |
Antreesy
approved these changes
Oct 28, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/reopen-window-on-mac
branch
from
October 28, 2024 15:57
19a10cc to
edd11d9
Compare
ShGKme
enabled auto-merge
October 28, 2024 15:57
This was referenced Nov 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Unlike other OS, when all windows are closed on macOS, the app is still kept running (app's menu bar is active, icon in the Dock looks like open's app icon).
New click on the Dock icon should "activate" the app and create the window again.
But the window is created hidden by default (stays in the system tray).
The fix - explicitly show the window on activate.