Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle system theme change #766

Merged
merged 5 commits into from
Aug 23, 2024
Merged

fix: handle system theme change #766

merged 5 commits into from
Aug 23, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 23, 2024

☑️ Resolves

Preparation to complete theme change support.

  • Before, there was no support for the default Nextcloud theme (= system preferences)
    • There where only light and dark theme
    • App checked system preferences only on init
  • Now:
    • Also load so called plain theme styles with prefers-color-scheme like the server does
    • Initially set default theme instead of specific
    • This allows handling system theme change in a native way like server does

🖼️ Screenshots

theme-change.mp4

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review labels Aug 23, 2024
@ShGKme ShGKme requested a review from Antreesy August 23, 2024 08:07
@ShGKme ShGKme self-assigned this Aug 23, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 23, 2024

Note: avatar change is a new feature of spreed PR

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, really nice!

Don't you want to add a toggle to control it locally in client?

@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 23, 2024

Don't you want to add a toggle to control it locally in client?

I do, it's several separated PRs.

Just found this issue in progress. Debugging system theme switch didn't work in Talk Desktop

@ShGKme ShGKme merged commit 398db0d into main Aug 23, 2024
7 checks passed
@ShGKme ShGKme deleted the fix/style-fetching-with-plain branch August 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants