-
Notifications
You must be signed in to change notification settings - Fork 31
chore: split value and ID parsing into separate methods #1887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d9ae0b9 to
92ad414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update
tables/lib/Service/RowService.php
Lines 315 to 317 in e761f16
| if ($columnBusiness->canBeParsed($value, $column)) { | |
| return json_decode($columnBusiness->parseValue($value, $column), true); | |
| } |
@enjeck No, because in this place for type selection there is already a value id |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to also have a test for the selection column, considering we have https://github.com/nextcloud/tables/blob/main/tests/unit/Service/ColumnTypes/TextLinkBusinessTest.php too
Created new issue at #1994 |
92ad414 to
49ff88b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with how this looks, will wait for @blizzz to check too
a02d387 to
b05eb15
Compare
|
@enjeck |
Signed-off-by: ailkiv <a.ilkiv.ye@gmail.com>
b05eb15 to
59cd04b
Compare
These changes allow for a clear separation of ID parsing and display value parsing, which is important for correct import and validation of data in tables.