Cannot edit table rows after update to 0.6.4

[olvidalo]

Steps to reproduce

Since updating from v0.6.0 to v0.6.1, I cannot edit existing rows in tables. I can create new rows and edit or delete those just fine.

1. Have table crated with v0.6.0 or below and populated with rows
2. Edit existing row

This happens with all tables, not a single specific one.

Please let me know If I can help with debugging by providing a database dump or other information

Expected behavior

Changes should be saved.

Actual behavior

Changes are not saved and I get an "unknown error".

Tables app version

0.6.4

Browser

Chrome 120

Client operating system

Mac

Operating system

Linux

Web server

Apache

PHP engine version

PHP 8.1

Database

MySQL

Additional info

From endpoint index.php/apps/tables/row/5:

{message: "Column with id 20 is not part of table with id 3"}

[olvidalo]

In rows with this issue, some of the arrays in data had objects mixed in with a columnId of a column from different tables. I fixed this for me by going through the rows and filtering out row data objects with a columnId not belonging to the table the row belongs to.

Feel free to close, but it would be interesting to find out when and how these values ended up in there. Maybe it was a bug in a previous version. I'll keep an eye on it and will open an issue if it happens again.

[juliusknorr]

@datenangebot I think we've had that case in our example data set, did we address this with #749 so unrelated columns are skipped in the new structure?

[datenangebot]

@datenangebot I think we've had that case in our example data set, did we address this with #749 so unrelated columns are skipped in the new structure?

Yes, with the new structure we always need the columns to get or set row data. In combination with the permissions service that kicks in on every loading of the column objects, we ensure that we only have allowed data-column combinations. But we should focus on this specially in the update process. We did that already but lets double check that!

[enjeck]

@olvidalo Is this still a problem?

[olvidalo]

No, for me it hasn't occurred anymore 👍