Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log messages when no model found #869

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

victorlap
Copy link
Contributor

This PR aims to fix #793.

I've separated the fact that a model could not be found from the other possible service exceptions. When such a case is found, it now only logs to the debug log. This might technically be duplicate, but I think it's good to include anyways for debugging purposes.

@victorlap victorlap changed the title Reduce log messages when no model Reduce log messages when no model found Apr 12, 2024
@victorlap victorlap force-pushed the reduce-log-messages-when-no-model branch 2 times, most recently from 0a07172 to 898cf95 Compare April 12, 2024 12:18
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR :)

I tested it and it works. I also left some minor feedback.

lib/Exception/ModelNotFoundException.php Outdated Show resolved Hide resolved
victorlap and others added 3 commits August 20, 2024 12:20
Signed-off-by: Victor Lap <victorlap@outlook.com>
Signed-off-by: Victor Lap <victorlap@outlook.com>
Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Victor <victorlap@outlook.com>
@susnux susnux force-pushed the reduce-log-messages-when-no-model branch from b2a6d71 to 8050aa5 Compare August 20, 2024 10:20
@susnux susnux requested a review from st3iny August 20, 2024 10:21
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick tests seems to work fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too verbose logs when model not found
4 participants