Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NewMessageUploadEditor): multiple files sharing support ๐Ÿ–ผ๏ธ+๐Ÿ–ผ๏ธ #8949

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 3, 2023

โ˜‘๏ธ Resolves

  • Support sending and receiving a group of shared files in a single message
  • Fix #โ€ฆ

๐Ÿ–Œ๏ธ UI Checklist

๐Ÿ–ผ๏ธ Screenshots / Screencasts

๐Ÿš๏ธ Before ๐Ÿก After
B A

๐Ÿšง Tasks

  • Mobile clients support:
    • As per backend setup, if message with file share contains a caption, it will replace the default message text ({file}). So we need to manually add references to the message text (see Message.vue)
    • When multiple files are loaded, they'll get indexed references - file-1, file-2 (and file-missing-3 for files deleted afterwards)
    • When sending multiple files, we still need to upload it via apps/files_sharing/api/v1/shares one by one, but metadata object should contain 'noMessage: true' to nont generate a separate message for each file. Instead, we're sending a new request to apps/spreed/api/v1/chat/{token}/share-files with caption and share ids of all the uploaded files
  • Autotests
  • Capabilities
  • Silent sending - check if possible
  • User bubbles - don't render for prefilled messages
  • Manual testing
  • Visual check
  • Code review

๐Ÿ Checklist

  • ๐ŸŒ Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ๐Ÿ–Œ๏ธ Design was reviewed, approved or inspired by the design team
  • โ›‘๏ธ Tests are included or not possible
  • ๐Ÿ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy marked this pull request as draft March 3, 2023 13:30
@Antreesy Antreesy force-pushed the feature/5354/upload-media-caption branch 2 times, most recently from 0bd1b16 to a46c540 Compare March 15, 2023 09:53
@nickvergessen nickvergessen added this to the ๐Ÿ’” Backlog milestone Apr 17, 2023
@Antreesy Antreesy force-pushed the feature/5354/upload-media-caption branch from a46c540 to 9949d34 Compare July 4, 2023 10:22
@Antreesy Antreesy force-pushed the feature/5354/upload-media-caption branch from 9949d34 to ae31045 Compare July 25, 2023 15:36
@Antreesy Antreesy changed the title Adding caption to the uploaded media [web draft] Caption to file share / Share a group of files Jul 26, 2023
@Antreesy Antreesy changed the title Caption to file share / Share a group of files feat(NewMessageUploadEditor) - caption to file share / share a group of files Jul 26, 2023
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice generally! Some feedback:

  • In the modal, the "Send" button is now not primary anymore, would be cool if the "Paper plane" icon button would be a primary button icon+text
  • Currently when composing, the images are above the text, but when sending the text comes first. In other messengers, when you send a message with a picture, usually the picture is above the text too.
  • Sort of related to the previous point, maybe it would be good to put the photos next to each other or tile them somehow else when there are multiple ones. Otherwise the text and photos are very far apart and the message also takes a lot of space if you send a message with 10 pictures

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feature/5354/upload-media-caption branch from ea60a3c to d8367a3 Compare January 19, 2024 20:37
@Antreesy Antreesy changed the title feat(NewMessageUploadEditor) - caption to file share / share a group of files feat(NewMessageUploadEditor): multiple files sharing support ๐Ÿ–ผ๏ธ+๐Ÿ–ผ๏ธ Jan 19, 2024
@Antreesy
Copy link
Contributor Author

Rebased onto master, dropped all irrelevant/outdated/conflicted code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants