-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NewMessageUploadEditor): multiple files sharing support ๐ผ๏ธ+๐ผ๏ธ #8949
Draft
Antreesy
wants to merge
1
commit into
main
Choose a base branch
from
feature/5354/upload-media-caption
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested changes
Mar 3, 2023
0bd1b16
to
a46c540
Compare
a46c540
to
9949d34
Compare
9949d34
to
ae31045
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super nice generally! Some feedback:
- In the modal, the "Send" button is now not primary anymore, would be cool if the "Paper plane" icon button would be a primary button icon+text
- Currently when composing, the images are above the text, but when sending the text comes first. In other messengers, when you send a message with a picture, usually the picture is above the text too.
- Sort of related to the previous point, maybe it would be good to put the photos next to each other or tile them somehow else when there are multiple ones. Otherwise the text and photos are very far apart and the message also takes a lot of space if you send a message with 10 pictures
9 tasks
99c9c58
to
a5f7e45
Compare
This was referenced Oct 16, 2023
a5f7e45
to
ea60a3c
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
ea60a3c
to
d8367a3
Compare
Rebased onto master, dropped all irrelevant/outdated/conflicted code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
enhancement
feature: upload & shares & voice ๐ค๐๏ธ
Sharing files into a chat and audio recordings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
โ๏ธ Resolves
๐๏ธ UI Checklist
๐ผ๏ธ Screenshots / Screencasts
๐ง Tasks
{file}
). So we need to manually add references to the message text (see Message.vue)file-1
,file-2
(andfile-missing-3
for files deleted afterwards)apps/files_sharing/api/v1/shares
one by one, but metadata object should contain 'noMessage: true' to nont generate a separate message for each file. Instead, we're sending a new request toapps/spreed/api/v1/chat/{token}/share-files
with caption and share ids of all the uploaded files๐ Checklist