Allow to disable public conversations #8357
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added spreed application config parameter `public_rooms_allowed` to disallow creating of rooms with public (guest via link) access (i.e. for internal Nextcloud setups). Use ``` occ config:app:set spreed public_rooms_allowed --value 'yes' ``` to allow (default if not set) and ``` occ config:app:set spreed public_rooms_allowed --value 'no' ``` to disallow creating of rooms with public access. Related: #521 Author-Change-Id: IB#1126215 Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
…owed Fixes: a38fdfd Related: #8082 (review) Author-Change-Id: IB#1126215 Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
enhancement
feature: settings ⚙️
nickvergessen
commented
Nov 16, 2022
src/components/ConversationSettings/ConversationSettingsDialog.vue
Outdated
Show resolved
Hide resolved
nickvergessen
commented
Nov 16, 2022
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue
Outdated
Show resolved
Hide resolved
|
@pboguslawski shall we take over the remaining tasks? |
|
No time resources now to help; feel free to adjust our PR according to your best practices. Will take a look at result in a few days. Thank you. |
|
Didn't notice any problems in your solution.
Yes please. |
nickvergessen
modified the milestones:
v16.0.0-beta.1,
🚀 Next Beta (26),
🖤 Next Major (27)
nickvergessen
modified the milestones:
v19.0.0-beta.3,
💞 Next Beta (29),
v19.0.0-beta.4,
💙 Next Major (30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 TODO
Follow up possible
🏁 Checklist
docs/has been updated or is not required